Set TOpPattern=kOpaque for scatter_nd #7464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
I'm not very familiar with fusion. I should have guess that this would cause an issue.
Thanks @apivovarov!
|
@apivovarov Can you please add the failing test from the discuss post? And also please add a comment on the lines of " |
apivovarov
force-pushed
the
scatter_nd
branch
from
d280118
to
8616b7d
Compare
apivovarov
force-pushed
the
scatter_nd
branch
from
8616b7d
to
b8b0b82
Compare
tqchen
approved these changes
Feb 18, 2021
|
Thanks @apivovarov for catching the problem! Thanks @anijain2305 @tkonolige |
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Feb 22, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
TOpPattern=kOpaqueforscatter_ndop to fix the issue described herehttps://discuss.tvm.apache.org/t/scatter-nd-and-concatenate-fails/9138
@masahi @anijain2305 @tkonolige @haan