Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tvmc version from tvm #7478

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

NicolaLancellotti
Copy link
Contributor

@NicolaLancellotti NicolaLancellotti commented Feb 19, 2021

In TVMC we currently collect the version from the installed version of the "tvm" package. As we also distribute TVM packaged as "tlcpack", this change makes the version to be collected consistently, no matter how TVM is installed, by using the tvm.version variable, rather than pkg_resources.

Change-Id: I6a6e78080f36e4e3e1689e03ea48e759fcd8e466
@leandron
Copy link
Contributor

cc @comaniac for a review on this one, when possible

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 256b9cf into apache:main Feb 19, 2021
@comaniac
Copy link
Contributor

Thanks @NicolaLancellotti @leandron

masahi pushed a commit to masahi/tvm that referenced this pull request Feb 22, 2021
Change-Id: I6a6e78080f36e4e3e1689e03ea48e759fcd8e466
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
Change-Id: I6a6e78080f36e4e3e1689e03ea48e759fcd8e466
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
Change-Id: I6a6e78080f36e4e3e1689e03ea48e759fcd8e466
@NicolaLancellotti NicolaLancellotti deleted the tvmc_version branch May 26, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants