-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Add a new intrinsic count leading zeros for LLVM and SPIR-V #7825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Apr 14, 2021
Good to go? Or any comments on the discussion points above @tqchen @junrushao1994 @vinx13 @zxybazh |
junrushao
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
tqchen
approved these changes
Apr 16, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 22, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new intrinsic
clz
to LLVM and SPIRV per discussion in #7669 (comment).The motivation is to compute integer
ceil(log2(x))
without using log2, since SPIR-V doesn't support log2 on fp64. Using this new intrinsic, we can compute integerceil(log2(x))
as follows:LLVM has
ctlz
intrinsic which we can use directly. SPIRV doesn't have clz intrin but it does haveFindUMsb
.https://llvm.org/docs/LangRef.html#llvm-ctlz-intrinsic
https://www.khronos.org/registry/spir-v/specs/1.0/GLSL.std.450.html
Some discussion points:
clz
on zero, because the LLVM doc above suggestsclz(0)
is not well supported by backends. Seeis_zero_undef
argument in the llvm doc for more details.clz
on negative integers?@tqchen @junrushao1994 @vinx13 @zxybazh