[TensorIR][PASS][M1c] CompactBufferAllocation #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Apr 26, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
xqdan
reviewed
Apr 27, 2021
| return _ffi_api.ConvertBlocksToOpaque() | ||
|
|
||
|
|
||
| def CompactBufferAllocation(): |
There was a problem hiding this comment.
So，is this pass doing the same job as InferBound?
There was a problem hiding this comment.
Yes, the functionality should be similar, except that infer bound needs to walk through the schedule tree, while in this case the split/reorder already updated the index, so the impl should be simpler
29 tasks
junrushao
approved these changes
Apr 27, 2021
xqdan
approved these changes
Apr 28, 2021
jcf94
approved these changes
Apr 28, 2021
|
Merged. Thanks! @Hzfengsy @tqchen @comaniac @junrushao1994 @xqdan |
29 tasks
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the TensorIR upstreaming effort (#7527) as one of the M1c stages, introducing the pass
ConvertBlocksToOpaqueandCompactBufferAllocationPass
ConvertBlocksToOpaquewill substitute all the block vars with the PrimExprs they are bound to its iter_values and convert blocks into opaque ones.Pass
CompactBufferAllocationcompacts the buffer access region by removing the buffer regions that are not accessed.These two passes both are important passes for converting schedulable TensorIR to low-level tir.
cc @tqchen @junrushao1994 @comaniac @xqdan @jroesch
cc @tqchen @comaniac @jroesch @junrushao1994