[Relay][Autoscheduler] Fix autoscheduler matmul without units. #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbrookhart @merrymercy can you guys take a look at this fix? |
merrymercy
approved these changes
May 2, 2021
mbrookhart
approved these changes
May 3, 2021
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…e#7957) * Fix autoscheduler matmul without units. * Fix lint.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…e#7957) * Fix autoscheduler matmul without units. * Fix lint.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…e#7957) * Fix autoscheduler matmul without units. * Fix lint.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…e#7957) * Fix autoscheduler matmul without units. * Fix lint.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…e#7957) * Fix autoscheduler matmul without units. * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autoscheduling a dense (or matmul) operator, sometimes the layout will be rewritten to have more than two axes. The shape function in relay only deals with this properly when the
unitsattribute is provided. However, some of our frontends do not specify units when constructing a graph, resulting in compilation errors after autoscheduling. This PR adds special handling for rewritten dense ops to fix the problem.