-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped Ubuntu version to 18.04 for ci_gpu #7970
Conversation
Change-Id: I8b13fda08ab002c16a082baaaedd973a063fab99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good move to update it to 18.04, mostly because 16.04 is now EOL (https://ubuntu.com/about/release-cycle).
For the sake of this PR, can you clarify what is the error you see?
Also cc @tqchen
@leandron I needed to re-run failed unit test inside ci_gpu docker environment, using my local tvm build and had a linkage error against libc. |
cc @jroesch i think we should move all containers at once rather than just ci_gpu, though. |
So I guess what you're suggesting is to update all the existing 16.04 images to 18.04? Do you think we should do this on this PR? I think we can do that, and I think it is a good move as 16.04 is now EOL, just would like to have a decision on what needs to be done. |
Jared thinks we should just do it on this PR and perform the update, but let's see what we are currently blocked on. Created a GH tracking issue #7995. |
hi guys, sorry for the delay here. we (@tkonolige and i) are going to attempt to update to 18.04 as part of #7995. we'll patch this PR and rev all the dockerfiles to 18.04, then see if we can build and get tests passing without the GPU driver issue. will send further updates to the GH issue. if our tests pass, we can merge either this PR or another like it which bumps all Dockerfiles, and then flip the CI images in Jenkinsfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay sorry I was talking past myself. as @tkonolige pointed out, all other container are on 18.04 already. merging to get this into #7995 .
Change-Id: I8b13fda08ab002c16a082baaaedd973a063fab99
Change-Id: I8b13fda08ab002c16a082baaaedd973a063fab99
Change-Id: I8b13fda08ab002c16a082baaaedd973a063fab99
Bumped Ubuntu version to 18.04 for ci_gpu