[FIX,DOCS] Prevent segfault when building docs when VTA is not available #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! VTA has been a thorn for me for a while, so this helps. I'll also update my own environment to make sure it's installed. |
tqchen
approved these changes
May 6, 2021
tqchen
requested changes
May 7, 2021
| @@ -63,6 +63,8 @@ | |||
|
|
|||
| # Make sure that TVM was compiled with RPC=1 | |||
| assert tvm.runtime.enabled("rpc") | |||
| # Make sure vta is available | |||
| assert tvm.get_global_func("tvm.contrib.vta.init", True) is not None | |||
There was a problem hiding this comment.
This function is not available in simulator and only available in rpc server to initialize the remote bitstream
There was a problem hiding this comment.
What function can I check then?
There was a problem hiding this comment.
I believe #7761 already checks if vta binary is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hogepodge