[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit #7997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lunderberg please try running the CI again |
Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a segfault on exit when using some nvidia drivers.
Lunderberg
force-pushed
the
vulkan_device_api_destructor
branch
from
c94c86a
to
1af9197
Compare
masahi
approved these changes
May 11, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 19, 2021
…che#7997) Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a segfault on exit when using some nvidia drivers. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 22, 2021
…xit (apache#7997)" This reverts commit 58c3413.
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 23, 2021
…xit (apache#7997)" This reverts commit 58c3413.
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 27, 2021
…xit (apache#7997)" This reverts commit 58c3413.
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 27, 2021
…xit (apache#7997)" This reverts commit 58c3413.
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 30, 2021
commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 30, 2021
commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support
masahi
added a commit
to masahi/tvm
that referenced
this pull request
May 31, 2021
commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jun 2, 2021
commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support
masahi
added a commit
that referenced
this pull request
Jun 2, 2021
* Initial import commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support * fix bad merge * fix cpplint * fix pylint * more cpplint fix * fix compiler warning * add doc * add tests * typo fixed * support axes argument in topi cpp strided slice * Properly test axes argument in relay tests * fix bad merge (revert vm change) * fix tests
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…che#7997) Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a segfault on exit when using some nvidia drivers. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* Initial import commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support * fix bad merge * fix cpplint * fix pylint * more cpplint fix * fix compiler warning * add doc * add tests * typo fixed * support axes argument in topi cpp strided slice * Properly test axes argument in relay tests * fix bad merge (revert vm change) * fix tests
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…che#7997) Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a segfault on exit when using some nvidia drivers. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* Initial import commit 667011f Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 16:28:57 2021 +0900 Squashed commit of the following: commit 95242d8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 15:45:19 2021 +0900 Add function attribute for shape func for profiling commit b8ede24 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 10:21:06 2021 +0900 layout transform support complete commit 5782b70 Author: Masahiro Masuda <masahi129@gmail.com> Date: Thu May 27 08:31:11 2021 +0900 support layout transform part1 commit e94aa6b Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 19:47:46 2021 +0900 moved utilities to its own file commit 8bf8891 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:39:50 2021 +0900 fix format commit e89d599 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:33:02 2021 +0900 ToVec -> ConvertToVec commit 001982c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:26:56 2021 +0900 format commit fae57f9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:24:35 2021 +0900 use Any for relay type rel path commit 053eee2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 17:14:44 2021 +0900 fix commit fbb099c Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:39:37 2021 +0900 refactor type rel commit ecfe3cd Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:23:47 2021 +0900 working commit b357c2f Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 16:07:07 2021 +0900 refactoring output shape calc commit f69ef40 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 14:23:36 2021 +0900 bug fix end param init commit a5611c9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:31 2021 +0900 fix test shape commit e79931a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:42:03 2021 +0900 dyn slice tests left as todo now work commit 7db4cea Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 13:36:30 2021 +0900 remove dynamic input specific op commit 510bce6 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 12:52:30 2021 +0900 refactoring dynamic slice commit 1b3969a Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 09:06:46 2021 +0900 fix slice axes dispatch commit 9a79560 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:32:54 2021 +0900 refactor compute commit 80442f8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 08:11:18 2021 +0900 fixed output shape, refactored version working commit d2538ae Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 07:56:05 2021 +0900 restore another slice variant commit 36aa777 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon May 24 06:41:50 2021 +0900 refactoring slice with axes commit 32698b7 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 13:11:01 2021 +0900 fix axes null check commit 54fb723 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 12:52:18 2021 +0900 Revert "[Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit (apache#7997)" This reverts commit 58c3413. commit 37eaf57 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:30:37 2021 +0900 remove wip layout transform support for slice with axes commit 9bcb2ad Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 18:01:59 2021 +0900 fix pylint commit 7063a09 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:57:03 2021 +0900 minor fix commit 96c9231 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:54:16 2021 +0900 support dynamic scatter nd commit d4a4db8 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:33:19 2021 +0900 gather_dim -> num_indices_per_tuple commit a489375 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:23:46 2021 +0900 add dynamic gather_nd test commit 533854a Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 17:18:26 2021 +0900 refactor gather_nd ref funcs commit 36a4501 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 14:36:34 2021 +0900 add gather_nd shape func commit 1853c35 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat May 22 04:20:39 2021 +0900 add eyelike support commit 150e945 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 04:08:37 2021 +0900 migrating inlined topi compute to topi/transform.h commit 763ac37 Author: Masahiro Masuda <masahi129@gmail.com> Date: Fri May 21 03:45:37 2021 +0900 strided slice with axes support * fix bad merge * fix cpplint * fix pylint * more cpplint fix * fix compiler warning * add doc * add tests * typo fixed * support axes argument in topi cpp strided slice * Properly test axes argument in relay tests * fix bad merge (revert vm change) * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a sporadic segfault on exit when using some nvidia drivers.