[Codegen] Use "target.build.$TARGET_KIND" for all codegen functions. #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lunderberg yeah |
|
@areusch Awesome. In that case, removing the special case for |
areusch
approved these changes
May 28, 2021
- Removed special case for "micro_dev" target. Instead, register BuildCHost as both "target.build.c" and "target.build.micro_dev". - Renamed "target.build.build.aocl_sw_emu" to "target.build.aocl_sw_emu". Appears to be a typo introduced in #841725cc585
device_api.micro_dev was removed in 745e542, but several references still remained.
|
Thank you! Rebased this morning to remove conflict with main, no other changes made from the approved version. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8071) * [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions. - Removed special case for "micro_dev" target. Instead, register BuildCHost as both "target.build.c" and "target.build.micro_dev". - Renamed "target.build.build.aocl_sw_emu" to "target.build.aocl_sw_emu". Appears to be a typo introduced in #841725cc585 * [micro_dev] Removed references to non-existent micro_dev device_api.micro_dev was removed in 745e542, but several references still remained. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8071) * [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions. - Removed special case for "micro_dev" target. Instead, register BuildCHost as both "target.build.c" and "target.build.micro_dev". - Renamed "target.build.build.aocl_sw_emu" to "target.build.aocl_sw_emu". Appears to be a typo introduced in #841725cc585 * [micro_dev] Removed references to non-existent micro_dev device_api.micro_dev was removed in 745e542, but several references still remained. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while writing documentation that not all codegen functions
follow the same naming pattern. Made changes below for consistency,
ease of locating a codegen function.
Removed special case for "micro_dev" target. Instead, register
BuildCHost as both "target.build.c" and "target.build.micro_dev".
Renamed "target.build.build.aocl_sw_emu" to
"target.build.aocl_sw_emu". Appears to be a typo introduced in
#841725cc585