Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] [Tensorflow2] Added test infrastructure for TF2 frozen models #8074

Merged
merged 10 commits into from
May 25, 2021
120 changes: 120 additions & 0 deletions tests/python/frontend/tensorflow2/common.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# pylint: disable=import-self, invalid-name, unused-argument, too-many-lines, len-as-condition, broad-except
# pylint: disable=import-outside-toplevel, redefined-builtin
"""TF2 to relay converter test utilities"""

import tvm
from tvm import relay

from tvm.runtime.vm import VirtualMachine
import tvm.contrib.graph_executor as runtime
from tvm.relay.frontend.tensorflow import from_tensorflow
import tvm.testing

import tensorflow as tf
from tensorflow.python.eager.def_function import Function


def vmobj_to_list(o):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another vmobj_to_list in tests/python/frontend/tensorflow/test_forward.py, it would be good to merge this same-name function together, looks they are quite similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yongwww for the comments. I addressed them in the new commits.

In this commit I do not introduce a new frontend code for TF2 models. That I will address in a new PR that is designed to handle TF2 style control flows and will also inherit some code from TF1 frontend code, mostly the ops. The structure of the PRs should follow the pattern as discussed in this thread, especially in this comment as below:

#4102 (comment)

if isinstance(o, tvm.nd.NDArray):
out = o.asnumpy().tolist()
elif isinstance(o, tvm.runtime.container.ADT):
result = []
for f in o:
result.append(vmobj_to_list(f))
out = result
else:
raise RuntimeError("Unknown object type: %s" % type(o))
return out


def run_tf_code(func, input_):
if type(func) is Function:
out = func(input_)
if isinstance(out, list):
a = [x.numpy() for x in out]
else:
a = out.numpy()
else:
a = func(tf.constant(input_))
if type(a) is dict:
a = [x.numpy() for x in a.values()]
if len(a) == 1:
a = a[0]
elif type(a) is list:
a = [x.numpy() for x in a]
if len(a) == 1:
a = a[0]
else:
a = a.numpy()
return a


def compile_graph_runtime(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph Runtime is now Graph Executor, may want to rename these functions

mod, params, target="llvm", target_host="llvm", opt_level=3, output_sig=None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output_sig is unused here and in compile_vm(), is this intended? What is output_sig?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a mistake from refactoring, output_sig are the outputs that should only be passed to frontend parser code, not to compiler

):
with tvm.transform.PassContext(opt_level):
lib = relay.build(mod, target=target, target_host=target_host, params=params)
return lib


def compile_vm(
mod, params, target="llvm", target_host="llvm", opt_level=3, disabled_pass=None, output_sig=None
):
with tvm.transform.PassContext(opt_level, disabled_pass=disabled_pass):
mod = relay.transform.InferType()(mod)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think InferType is required here

vm_exec = relay.vm.compile(mod, target, target_host, params=params)
return vm_exec


def run_vm(vm_exec, input_, ctx=tvm.cpu(0)):
vm = VirtualMachine(vm_exec, ctx)
_out = vm.invoke("main", input_)
return vmobj_to_list(_out)


def run_graph(lib, input_, ctx=tvm.cpu(0)):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I like namerun_graph_runtime more

mod = runtime.GraphModule(lib["default"](ctx))
mod.set_input(0, input_)
mod.run()
_out = mod.get_output(0).asnumpy()
return _out


def compare_tf_tvm(gdef, input_, output_, vm=True, output_sig=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about changing vm to "runtime_mode" or runtime, since we have vm, graphruntime, interpreter

"""compare tf and tvm execution for the same input.

Parameters
----------
func: tf function. can be from saved model or not. different ways to pass input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see func in the arg list of the function compare_tf_tvm, please update them to keep docstring and definition identical

from saved model: <class 'tensorflow.python.saved_model.load._WrapperFunction'>
not from saved model: <class 'tensorflow.python.eager.def_function.Function'>

mod: compiled relay module (vm or graph runtime). converted from tf func.

input_: a single numpy array object

"""
mod, params = from_tensorflow(gdef, outputs=output_sig)
if vm:
exec_ = compile_vm(mod, params, output_sig=output_sig)
tvm_out = run_vm(exec_, input_)
else:
lib = compile_graph_runtime(mod, params, output_sig=output_sig)
tvm_out = run_graph(lib, input_)
tvm.testing.assert_allclose(output_, tvm_out, atol=1e-5)
Loading