[Target] Allow 'true' and 'false' strings in conversions to integer #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow Bool parameters to take true/false values instead of 0 and 1 only.
comaniac
reviewed
Jun 14, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8254) * [Target] Allow 'true' and 'false' strings in conversions to integer This will allow Bool parameters to take true/false values instead of 0 and 1 only. * Convert the string to lowercase. * Reserve memory for lowercase string * Add include <cctype>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8254) * [Target] Allow 'true' and 'false' strings in conversions to integer This will allow Bool parameters to take true/false values instead of 0 and 1 only. * Convert the string to lowercase. * Reserve memory for lowercase string * Add include <cctype>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow
Boolattributes to taketrue/falsevalues instead of 0 and 1 only.