-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metal to list of backends for TVMC #8282
Conversation
cc @elvin-n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AndrewZhaoLuo is there any way to add a test case for metal?
In case it is too challenging, it is ok, we just wait for CI and merge it.
Does our CI even test metal backend? Let me ask aroud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I agree with @leandron that it would be nice to have a test case for Metal.
Does our CI even test metal backend? Let me ask aroud
Maybe I'm mistaking (please, someone correct me if I'm wrong), but as far as I know, we don't run metal backend tests in our CI. And also unfortunately we have only few tests on Metal. But in case if such test will exist, we could run it locally and check that we didn't break something by some new changes.
Also, we are locally working on extending CI for validation on different Apple devices, so in the future this functionality might be added to tvm repository and such tests for Metal will be executed in the CI.
Thanks for the clarification, that’s really helpful. |
Thanks @echuraev @AndrewZhaoLuo! |
Need this to test benchmarking for #8069