[ONNX] Wrap 'If' if it has multiple outputs #8385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch"
|
Thanks for this fix, it makes sense to me. Can you add a test case that triggers the previous error to |
|
@jwfromm |
jwfromm
approved these changes
Jul 5, 2021
|
@jwfromm |
|
@karljang This is now merged. Thanks for taking the initiative to make this fix and congrats on your first commit! |
|
@jwfromm |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [ONNX] Wrap 'If' if it has multiple outputs Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch" * [ONNX] Test If nodes with multiple output tensors * Fix formatting issues
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* [ONNX] Wrap 'If' if it has multiple outputs Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch" * [ONNX] Test If nodes with multiple output tensors * Fix formatting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this wrapper, an assertion in from_onnx() will fail with the
error message showing "Number of output mismatch"
The assertion check is here: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/onnx.py#L3597