Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Add Arduino CLI support to ci-qemu #8504

Merged
merged 6 commits into from
Aug 9, 2021

Conversation

guberti
Copy link
Member

@guberti guberti commented Jul 19, 2021

When merging Arduino support from #8493, we'd like to be able to add unit tests. Since no simulators exist for any of the boards we currently support, we will only be able to test project generation and compilation.

Specifically, this PR adds an ubuntu_install_arduino.sh script that installs arduino-cli via wget (as recommended) and then downloads the SDKs for two of the boards we support.

@guberti guberti force-pushed the ci-qemu-arduino-support branch from 56029c7 to 93c132a Compare July 20, 2021 20:42
@guberti guberti marked this pull request as ready for review July 26, 2021 17:58
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @guberti , see some comments inline

docker/install/ubuntu_install_arduino.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_arduino.sh Outdated Show resolved Hide resolved
@guberti guberti changed the title Add Arduino CLI support to ci-qemu [microTVM] Add Arduino CLI support to ci-qemu Aug 2, 2021
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guberti thanks for this change! Can you explain your plan on testing Arduino on ci_qemu?
Maybe add information about the board that you are using and etc.

@guberti
Copy link
Member Author

guberti commented Aug 5, 2021

As discussed with Mehrdad, the Sony Spresense SDK (the Arduino board I used for development) has a bug that prevents TVM from compiling. The fix is available on the development branch and will be released in version 2.3.0, but that has not yet occurred.

Instead of using a workaround (such as installing from the development branch or cherry-picking the commit), IMO it's better to just test on a different type of board. Commit fe1d4dd replaces the Spresense with the Arduino Due, which is much more popular and works without needing a crazy hack.

Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the image and tested it. LGTM!
Thanks!

@areusch areusch merged commit 39571c1 into apache:main Aug 9, 2021
@areusch
Copy link
Contributor

areusch commented Aug 9, 2021

thanks @guberti, the PR is now merged!

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Aug 11, 2021
* Add Arduino CLI support to ci-qemu

* Install latest version of Arduino SDK

* Remove unnecessary --fix-missing

* Tweak to clarify what URLs go with what

* Retrigger CI

* Temporarily replace buggy Spresense core
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Add Arduino CLI support to ci-qemu

* Install latest version of Arduino SDK

* Remove unnecessary --fix-missing

* Tweak to clarify what URLs go with what

* Retrigger CI

* Temporarily replace buggy Spresense core
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Add Arduino CLI support to ci-qemu

* Install latest version of Arduino SDK

* Remove unnecessary --fix-missing

* Tweak to clarify what URLs go with what

* Retrigger CI

* Temporarily replace buggy Spresense core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants