-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microTVM] Add Arduino CLI support to ci-qemu #8504
Conversation
56029c7
to
93c132a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @guberti , see some comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guberti thanks for this change! Can you explain your plan on testing Arduino on ci_qemu?
Maybe add information about the board that you are using and etc.
As discussed with Mehrdad, the Sony Spresense SDK (the Arduino board I used for development) has a bug that prevents TVM from compiling. The fix is available on the development branch and will be released in version 2.3.0, but that has not yet occurred. Instead of using a workaround (such as installing from the development branch or cherry-picking the commit), IMO it's better to just test on a different type of board. Commit fe1d4dd replaces the Spresense with the Arduino Due, which is much more popular and works without needing a crazy hack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the image and tested it. LGTM!
Thanks!
thanks @guberti, the PR is now merged! |
* Add Arduino CLI support to ci-qemu * Install latest version of Arduino SDK * Remove unnecessary --fix-missing * Tweak to clarify what URLs go with what * Retrigger CI * Temporarily replace buggy Spresense core
* Add Arduino CLI support to ci-qemu * Install latest version of Arduino SDK * Remove unnecessary --fix-missing * Tweak to clarify what URLs go with what * Retrigger CI * Temporarily replace buggy Spresense core
* Add Arduino CLI support to ci-qemu * Install latest version of Arduino SDK * Remove unnecessary --fix-missing * Tweak to clarify what URLs go with what * Retrigger CI * Temporarily replace buggy Spresense core
When merging Arduino support from #8493, we'd like to be able to add unit tests. Since no simulators exist for any of the boards we currently support, we will only be able to test project generation and compilation.
Specifically, this PR adds an
ubuntu_install_arduino.sh
script that installsarduino-cli
viawget
(as recommended) and then downloads the SDKs for two of the boards we support.