[CI] Disable pip cache when creating Docker images #8575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is a good practice to save storage space in the Docker images being created * Also sort pip package lists alphabetically
areusch
reviewed
Jul 28, 2021
| @@ -23,6 +23,9 @@ FROM ubuntu:18.04 | |||
| RUN apt-get update --fix-missing | |||
| RUN apt-get install -y ca-certificates gnupg2 | |||
|
|
|||
| # Globally disable pip cache | |||
| RUN pip config set global.cache-dir false | |||
There was a problem hiding this comment.
is it global.no-cache-dir or global.cache-dir?
There was a problem hiding this comment.
I tried it locally and it seems to work to set the global config and preventing the cache to be created.
When using it in an individual pip install —no-cache-dir foo it seems to be the way to disable in one instance, but I decided not going this way, because there is always a new pip install in those scripts.
areusch
approved these changes
Jul 28, 2021
mbaret
pushed a commit
that referenced
this pull request
Aug 2, 2021
* The fix to disable cache needs to run after pip is installed * This is quick follow up fix after #8575
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* This is a good practice to save storage space in the Docker images being created * Also sort pip package lists alphabetically
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* The fix to disable cache needs to run after pip is installed * This is quick follow up fix after apache#8575
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* This is a good practice to save storage space in the Docker images being created * Also sort pip package lists alphabetically
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* The fix to disable cache needs to run after pip is installed * This is quick follow up fix after apache#8575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable pip cache when creating Docker images:
docker/install/*.shscript, we re keeping a copy of it in/root/.cache/pip/*In summary, this saves around 700Mb on the ci_cpu image, and 1.6Gb on the ci_gpu image.
cc @tqchen @areusch @mbrookhart @Mousius for reviews