Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Reduce testing time of LSTM tests #8583

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

vvchernov
Copy link
Contributor

@vvchernov vvchernov commented Jul 29, 2021

The main aim of the patch to reduce time of testing of different modifications of LSTM layer implemented in pytorch frontend.
The following changings were done:

  1. Reduce input sequence size and batch size. Also other sizes was changed, they are taken from lstm test for onnx frontend
  2. Skip LSTM modification with projection. It is rare used and supported by pytorch framework only
  3. Skip tests which check onnx model LSTM modifications converted from pytorch model
  4. Weights are always randomly generated
    For points 2, 3 and 4: the code was not removed, the paths to it were commented only. It can be switch on in the future if need

@masahi please review this patch

@masahi
Copy link
Member

masahi commented Jul 29, 2021

@vvchernov How about we always use random weights at

for rnd_weights in (True, False):
?

Also please fix the lint issue.

@masahi masahi changed the title reduce testing time [Torch] Reduce testing time of LSTM tests Jul 29, 2021
@masahi masahi merged commit 97f147c into apache:main Jul 30, 2021
@masahi
Copy link
Member

masahi commented Jul 30, 2021

thanks @vvchernov !

@vvchernov
Copy link
Contributor Author

@masahi Thank you for help and good advices!

@vvchernov vvchernov deleted the vc/lstm_test_patch branch August 18, 2021 18:36
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* reduce testing time

* lint issues were resolved. weights for test are always randomly generated

Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* reduce testing time

* lint issues were resolved. weights for test are always randomly generated

Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants