[WIP] Revert lower tvm builtin change #8643
Conversation
zhanghaohit
requested review from
junrushao,
kparzysz-quic,
masahi,
tmoreau89,
tqchen,
vegaluisjose,
vinx13 and
ZihengJiang
as code owners
zhanghaohit
force-pushed
the
revert_lower_tvm_builtin_change
branch
from
d449808 to
4cf4dc5
Compare
jroesch
removed request for
vegaluisjose,
tmoreau89,
ZihengJiang and
kparzysz-quic
|
I’m not actually an expert in vta or opencl. CC @tmoreau89 if you are interested :-) |
|
Thanks for the WIP PR, please let me know when it's ready for review @zhanghaohit - and also please provide a short summary of the PR in the description box, thanks! |
|
@zhanghaohit looks like the CIs are green! Let me know when you'd like to change this PR to not WIP |
Hi @tmoreau89, this PR is actually the same as #8274 proposed by @mbrookhart . It is to show how to pass the CI if we want to revert the lower_tvm_builtin_change. I think it is better to let @mbrookhart apply the changes to his PR #8274, which has already much discussion and context there. I'll close this PR first, in order not to confuse. |
|
Huh, I thought I did this, to the tutorial, but it doesn't seem to be in my PR! Oops! I'll do this there, thanks. |
|
😳 Oops. Apparently I made this change locally and never pushed it upstream. Thank you for double checking me. |
|
Also, sorry I missed this last week, I was out on PTO. |
|
Ah no problem, my reaction times have been slow lately, I'm glad we're making forward progress. |
No description provided.