Move to new style issue template system #8898
Conversation
This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update.
|
This looks nice! CC: @tqchen |
.github/ISSUE_TEMPLATE/ci-update.md
Outdated
| --- | ||
| name: "\U0001F40B Update CI Docker Image" | ||
| about: Provide information on CI Docker Images requiring updates | ||
| title: "[CI] " |
There was a problem hiding this comment.
I would suggest using other tags like [Docker] or something else for updating CI docker images, because [CI] looks more like an CI issue (e.g., flaky test, machine down, etc) at the first glance. Since CI issue is not really a bug, we could still have a CI issue template to let users report CI running issues.
There was a problem hiding this comment.
On the other hand, [Docker] is a confusing name too, which might sound like docker-related but it’s actually CI upgrade 😆
There was a problem hiding this comment.
I was inclined to suggest we limit the amount of issue types but then this PR failed CI, so I've changed this to [CI Image] and created a [CI Issue] template as well. I don't think that's too many for people to pick through?
It's also worth noting we can use label as well as the title here if we wanted to create labels for filtering on, I would need someones help to make appropriate labels though.
There was a problem hiding this comment.
[CI Image] looks good to me. [CI Issue] looks a bit funny tho, as we are already creating an "issue" here lol
I'm fine if others feel CI failures are a kind of bugs. The downside is I don't think people can add labels to an issue by themselves unless they have the write permission (i.e., committer). It means we will need a committer to help add labels manually for created issues; otherwise we will need a bot to automatically add labels based on the issue content.
There was a problem hiding this comment.
By the power of the thesaurus I have renamed it CI Problem, though keen to hear whether people think we need another category.
On the labels point, the config appears to let me set labels, so I'm curious if it'll actually apply them when we open those issue types. When we see if that works we can decide if we want to try more of it?
There was a problem hiding this comment.
I'm not sure either. Maybe someone else could confirm? Anyways, I'm good with the current change.
There was a problem hiding this comment.
Following up on this thread, a new bug was raised (#8925) which had the label auto-applied so the config here overrides the need for a committer 🎉
There was a problem hiding this comment.
LGTM me modulo naming discussion will let @comaniac or @junrushao1994 merge it.
* main: [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests (apache#8902) [BUG] DataType Bug In SplitRel (apache#8899) Enable python debug runtime for exported network libraries (apache#8793) Set default value of p in LpPool as 2 (apache#8866) [Community] @Hzfengsy -> Committer (apache#8908) Trivial uTVM -> microTVM "spelling" fix to align with branding. (apache#8905) [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures (apache#8904) Move to new style issue template system (apache#8898) [Onnx] Support Negative Log Loss (apache#8872) [ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896) fix error report on Store (apache#8895) [Docker] Re-enabled automatic --tty flag when running bash. (apache#8861)
* Move to new style issue template system This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update. * Fix checkboxes * Codify the use of Discourse rather than raising issues * Change CI to CI Image and introduce CI Issue template * Fix poor english * Add more tags where we have them * CI Issue -> CI Problem
* Move to new style issue template system This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update. * Fix checkboxes * Codify the use of Discourse rather than raising issues * Change CI to CI Image and introduce CI Issue template * Fix poor english * Add more tags where we have them * CI Issue -> CI Problem
This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update.
I can't find a decent way of testing this but GitHub does seem to have acknowledged they are issue templates here: https://github.com/Mousius/tvm/blob/issue-templates/.github/ISSUE_TEMPLATE/bug-report.md