[Hexagon] Sort functions before adding to LLVM codegen #8948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different llvm::Module to be created each time, which can defeat debugging tools like -opt-bisect-limit. Sort the PrimFuncs in a deterministic way before adding them to the LLVM code generator.
kparzysz-quic
requested review from
junrushao,
masahi,
tqchen,
vinx13 and
ZihengJiang
as code owners
jroesch
reviewed
Sep 7, 2021
| @@ -730,6 +730,12 @@ runtime::Module BuildHexagon(IRModule mod, Target target) { | |||
| funcs.emplace_back(f); | |||
| } | |||
|
|
|||
| std::sort(funcs.begin(), funcs.end(), [](PrimFunc func_a, PrimFunc func_b) { | |||
There was a problem hiding this comment.
LGTM, is this something we should fix else where in the compiler? its probably good to add sorting/ordering for determinism.
There was a problem hiding this comment.
There are definitely more places in the compiler where the names should be sorted for reproducibility. I had a branch where I tried to make codegen more reproducible, but I can't find it. I remember adding sorts to llvm codegen as well as some places where IRModules were constructed.
There was a problem hiding this comment.
Here's a generalized version of this PR: #8958.
|
Closing in favor of PR #8958. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different
llvm::Moduleto be created each time, which can defeat debugging tools like-opt-bisect-limit.Sort the PrimFuncs in a deterministic way before adding them to the LLVM code generator.