[microTVM][autoTVM] Follow up fixes to #9003 #9018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kazum,
liangfu,
manupak,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
mehrdadh
force-pushed
the
fix_zephyr_tune_test_hw
branch
from
d0849cf to
0679917
Compare
mehrdadh
force-pushed
the
fix_zephyr_tune_test_hw
branch
from
0679917 to
2da1a7a
Compare
huajsj
reviewed
Sep 16, 2021
areusch
requested changes
Sep 16, 2021
| @@ -38,7 +42,7 @@ CRT_LIBS = $(patsubst %, $(BUILD_DIR)/crt/lib%.a, $(CRT_LIB_NAMES)) | |||
| CRT_INCLUDES = $(glob crt/include/**) | |||
|
|
|||
| $(BUILD_DIR)/crt/lib%.a: $(glob crt/src/runtime/%/*.c) | |||
| ${QUIET}cd crt && $(MAKE) \ | |||
| ${QUIET}cd crt && $(MAKE) -s \ | |||
There was a problem hiding this comment.
do you need this and verbose?
There was a problem hiding this comment.
yeah, otherwise you get messages like make[1]: Entering directory '/tmp/tmptwf17bxw/generated-project/crt'
mehrdadh
force-pushed
the
fix_zephyr_tune_test_hw
branch
2 times, most recently
from
2b31a1f to
84d738c
Compare
mehrdadh
force-pushed
the
fix_zephyr_tune_test_hw
branch
from
84d738c to
c5e8ee0
Compare
huajsj
approved these changes
Sep 16, 2021
|
|
||
| # measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner) | ||
| # | ||
| # measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner) |
There was a problem hiding this comment.
I think this is the tutorial format. Picked it up from other tutorials.
areusch
approved these changes
Sep 17, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: