Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Build] Move build module transformations and utilities to C++ #9103
[Core][Build] Move build module transformations and utilities to C++ #9103
Changes from 30 commits
c8eace9
8d6b228
ba8836e
b5bb9e8
f9372db
322f9f1
0c4a01d
73640e8
6904123
d0ba8b8
01b4ce3
6176155
df0c75d
09aaf88
311632b
0c28839
5008b75
f73791a
ba98e6f
f515c6f
6b366c3
1e24b25
af8c8e3
57b8039
0c4bf6d
41cf6f3
6e4f751
b7f27d0
e1658b5
a71a0af
0ca60e9
49cbe53
cd33d95
6e1203e
2c0305b
b955799
aed0765
c3505fa
2162c85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe sweep for leftover comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also rename the containing function, which is just a wrapper (which would really be renaming the contianing function to codegen but adding a backwards-compat
build_module
which warns about deprecation (there are some examples using warnings module i believe).