[TEST] Move llvm import test away from minimum test #9171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llvm import relies on the same system clang and llvm version and may be tricky to get right on all platforms. Given this is an advanced feature, and there has been some problems in windows(could relates to clang version update). This PR moves away from minimum tests.
tqchen
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy and
yzhliu
as code owners
junrushao
approved these changes
Oct 1, 2021
|
I suppose we should ping the llvm version some day |
For both stability and security reasons we should be pinning all dependencies, potentially something to consider before a |
|
Yes, we should followup, in this case. We need to pin both the system clang and llvm |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [TEST] Move llvm import test away from minimum test The llvm import relies on the same system clang and llvm version and may be tricky to get right on all platforms. Given this is an advanced feature, and there has been some problems in windows(could relates to clang version update). This PR moves away from minimum tests. * Update test_minimal_target_codegen_llvm.py * Update test_target_codegen_llvm.py Co-authored-by: Junru Shao <junrushao1994@gmail.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [TEST] Move llvm import test away from minimum test The llvm import relies on the same system clang and llvm version and may be tricky to get right on all platforms. Given this is an advanced feature, and there has been some problems in windows(could relates to clang version update). This PR moves away from minimum tests. * Update test_minimal_target_codegen_llvm.py * Update test_target_codegen_llvm.py Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvm import relies on the same system clang and llvm version and
may be tricky to get right on all platforms.
Given this is an advanced feature, and there has been some problems
in windows(could relates to clang version update).
This PR moves away from minimum tests.