Initial Implementation of TIRToRuntime Target hook #9190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
manupak,
masahi,
mbaret,
merrymercy,
tqchen,
trevor-m,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
This is the initial implementation which wires in a test case for TIRToRuntime, in order to get this working I re-used `CodegenCHost` as it implements all of the `Op`s required from the lowered `PrimFunc`. Currently, the `IRModule` is non-unified but in future work it should definitely do so, I wanted to implement the basics here to get the infra in place.
Mousius
force-pushed
the
tir-to-runtime
branch
from
aac882b
to
34ded72
Compare
Hzfengsy
reviewed
Oct 6, 2021
src/driver/driver_api.cc
Outdated
| @@ -34,6 +34,8 @@ | |||
| #include <mutex> | |||
| #include <stack> | |||
|
|
|||
| #include "../relay/backend/te_compiler.h" | |||
There was a problem hiding this comment.
I'm not sure it is needed in this file.
There was a problem hiding this comment.
Ah, good spot, this was when I was trying to bundle building a unified IRModule into this PR - I'll fix 😸
|
Thanks @Mousius. It looks good to me. |
mbs-octoml
approved these changes
Oct 8, 2021
| // can be used alongside the default host codegen based on device type | ||
| // this is so the correct code generator is used later instead of overriding the target. | ||
| // We need better support for inserting multiple kDLCPU targets as our current options | ||
| // are kDeviceKernelLaunch or not |
| @@ -401,12 +401,21 @@ std::pair<IRModule, IRModule> SplitDevHostFuncs(IRModule mod_mixed, const Target | |||
| auto opt_mixed = transform::Sequential(mixed_pass_list); | |||
| mod_mixed = opt_mixed(std::move(mod_mixed)); | |||
|
|
|||
| // We make an assumption here that the overriden host target | |||
There was a problem hiding this comment.
Heads up that @mikepapadim is working here in #9103
| } // namespace contrib | ||
| } // namespace relay | ||
|
|
||
| TVM_REGISTER_TARGET_KIND("example_target_hook", kDLCPU) |
There was a problem hiding this comment.
nit: example_target_kind
And maybe a comment -- 'here we register blah blah'.
|
@mbaret could you take a look, @mbs-octoml seems happy so I'm happy 😸 will look to follow up in a later PR on the minor nit. |
|
Thanks @Mousius, @mbs-octoml this is merged |
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
* Initial Implementation of TIRToRuntime Target hook This is the initial implementation which wires in a test case for TIRToRuntime, in order to get this working I re-used `CodegenCHost` as it implements all of the `Op`s required from the lowered `PrimFunc`. Currently, the `IRModule` is non-unified but in future work it should definitely do so, I wanted to implement the basics here to get the infra in place. * Fix heterogeneous compute with multiple kDLCPU targets * Remove rogue te_compiler.h include
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Initial Implementation of TIRToRuntime Target hook This is the initial implementation which wires in a test case for TIRToRuntime, in order to get this working I re-used `CodegenCHost` as it implements all of the `Op`s required from the lowered `PrimFunc`. Currently, the `IRModule` is non-unified but in future work it should definitely do so, I wanted to implement the basics here to get the infra in place. * Fix heterogeneous compute with multiple kDLCPU targets * Remove rogue te_compiler.h include
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Initial Implementation of TIRToRuntime Target hook This is the initial implementation which wires in a test case for TIRToRuntime, in order to get this working I re-used `CodegenCHost` as it implements all of the `Op`s required from the lowered `PrimFunc`. Currently, the `IRModule` is non-unified but in future work it should definitely do so, I wanted to implement the basics here to get the infra in place. * Fix heterogeneous compute with multiple kDLCPU targets * Remove rogue te_compiler.h include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation which wires in a test case for TIRToRuntime, in order to get this working I re-used
CodegenCHostas it implements all of theOps required from the loweredPrimFunc.Currently, the
IRModuleis non-unified but in future work it should definitely do so, I wanted to implement the basics here to get the infra in place.The example now shows how to register the target, and customize the pipeline with minimal additional work involved 😸