Add a 'rolling_buffer' scheduling primitive #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLancellotti
requested review from
areusch,
comaniac,
Hzfengsy,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
NicolaLancellotti
force-pushed
the
passes/rolling_buffer
branch
from
7e5bb57
to
28813b6
Compare
|
This is based on #7925 but in C++. |
NicolaLancellotti
force-pushed
the
passes/rolling_buffer
branch
2 times, most recently
from
e30c09c
to
25f32f3
Compare
Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126
Change-Id: Ic148264239eac7df7d976a6a3e15236935232792
NicolaLancellotti
force-pushed
the
passes/rolling_buffer
branch
from
25f32f3
to
53c1a99
Compare
|
I fixed the CI issues. |
|
@mbaret -- Would you be able to have a look and see if its matching the original approved implementation so that we could get this in ? Possibly follow up if and when concerns arises later ? |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Add a 'rolling_buffer' scheduling primitive Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com> * Fix lint problems Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126 * Remove designated initializers Change-Id: Ic148264239eac7df7d976a6a3e15236935232792 Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Add a 'rolling_buffer' scheduling primitive Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com> * Fix lint problems Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126 * Remove designated initializers Change-Id: Ic148264239eac7df7d976a6a3e15236935232792 Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Add a 'rolling_buffer' scheduling primitive Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com> * Fix lint problems Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126 * Remove designated initializers Change-Id: Ic148264239eac7df7d976a6a3e15236935232792 Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* Add a 'rolling_buffer' scheduling primitive Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com> * Fix lint problems Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126 * Remove designated initializers Change-Id: Ic148264239eac7df7d976a6a3e15236935232792 Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Add a 'rolling_buffer' scheduling primitive Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com> * Fix lint problems Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126 * Remove designated initializers Change-Id: Ic148264239eac7df7d976a6a3e15236935232792 Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add a rolling buffer scheduling primitive.
The pr is based on @mbaret's pr #7925 , and it differs in that the
InjectRollingBufferpass has been rewritten in C++, (originally it was written in Python).Also since the original pr was written, the TIR changed a bit, and as a consequence, some code has been moved between the visitors' methods.