[TVMScript][Fix] Add type hints for more uncovered cases #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shingjan
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
|
Thank you so much for acting swiftly on this!! BTW, would you mind also adding T.exp in the unittest? |
|
@shingjan please address comments above |
shingjan
force-pushed
the
tvmscript-type-hint-fix
branch
from
b38fccf
to
96740bc
Compare
|
@vinx13 Comments addressed. I fixed the CI issue by disabling the mypy check on slice index of that two lines. |
|
The following two errors should be fixed rather than skipped (if possible) |
|
It is an issue of mypy that can't be fixed - it requires slice must be constructed with int rather than custom type |
vinx13
reviewed
Nov 18, 2021
added 2 commits
November 18, 2021 13:30
|
There are still some CI error. Please make sure it can pass locally |
junrushao
requested changes
Nov 22, 2021
|
Shall we merge this PR? |
junrushao
approved these changes
Nov 22, 2021
vinx13
approved these changes
Nov 22, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* add support for prevously uncovered cases * remove PrimExpr import * add exp test and mypy ignore * disable ling too long * resolve long line * nit * add dtype to unary ops
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* add support for prevously uncovered cases * remove PrimExpr import * add exp test and mypy ignore * disable ling too long * resolve long line * nit * add dtype to unary ops
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* add support for prevously uncovered cases * remove PrimExpr import * add exp test and mypy ignore * disable ling too long * resolve long line * nit * add dtype to unary ops
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* add support for prevously uncovered cases * remove PrimExpr import * add exp test and mypy ignore * disable ling too long * resolve long line * nit * add dtype to unary ops
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* add support for prevously uncovered cases * remove PrimExpr import * add exp test and mypy ignore * disable ling too long * resolve long line * nit * add dtype to unary ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add type hints for some uncovered cases in TVMScript.
cc: @junrushao1994 @vinx13