-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for HexagonBuffer #9736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adstraw
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
a team
as code owners
December 14, 2021 01:11
adstraw
requested review from
kazum,
liangfu,
masahi,
tmoreau89,
vinx13 and
ZihengJiang
as code owners
December 14, 2021 16:03
adstraw
force-pushed
the
hexagon-buffer-unit-test
branch
from
December 14, 2021 21:03
0728ef2
to
6cd106a
Compare
jroesch
approved these changes
Dec 15, 2021
tmoreau89
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adstraw - really awesome to see these unit tests !
AndrewZhaoLuo
pushed a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Dec 16, 2021
* Add unit tests for HexagonBuffer * fix build error for signed / unsigned comparison
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Add unit tests for HexagonBuffer * fix build error for signed / unsigned comparison
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Add unit tests for HexagonBuffer * fix build error for signed / unsigned comparison
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
* Add unit tests for HexagonBuffer * fix build error for signed / unsigned comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for HexagonBuffer class which run on CPU (not Hexagon) and test out full capabilities of HexagonBuffer e.g. discontiguous allocation that are not currently exposed through the Hexagon Device API.