Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Update Rust bindings #9808

Merged
merged 2 commits into from
Jan 9, 2022
Merged

[Rust] Update Rust bindings #9808

merged 2 commits into from
Jan 9, 2022

Conversation

gussmith23
Copy link
Contributor

@gussmith23 gussmith23 commented Dec 29, 2021 •
edited
Loading

  • Adds Rust bindings.
  • Fixes Rust bindings that have been broken by changes on the C++ side.
  • Introduces various other changes to make Rust bindings work (namely, changing things to use tvm::String).

I'm still unsure on how to construct the deleter on the Rust side, see the todo!.

@jroesch

@gussmith23 gussmith23 changed the title [Rust] Update Rust bindings [WIP][Rust] Update Rust bindings Dec 29, 2021
@gussmith23 gussmith23 marked this pull request as ready for review December 30, 2021 23:33
@gussmith23 gussmith23 changed the title [WIP][Rust] Update Rust bindings [Rust] Update Rust bindings Dec 30, 2021
@masahi masahi merged commit e97a3f2 into apache:main Jan 9, 2022
Raghav-Chakravarthy pushed a commit to Raghav-Chakravarthy/tvm that referenced this pull request Jan 28, 2022
@gussmith23 @AD1024 @Raghav-Chakravarthy
[Rust] Update Rust bindings (apache#9808)
c5950cd 
* Update Rust bindings

* fmt

Co-authored-by: AD1024 <dh63@cs.washington.edu>
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@gussmith23 @AD1024 @ylc
[Rust] Update Rust bindings (apache#9808)
f27ee77 
* Update Rust bindings

* fmt

Co-authored-by: AD1024 <dh63@cs.washington.edu>
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gussmith23 @masahi @AD1024