Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge type system modules into core module #118

Closed
reckart opened this issue Jan 27, 2023 · 0 comments
Closed

Merge type system modules into core module #118

reckart opened this issue Jan 27, 2023 · 0 comments
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented Jan 27, 2023

Describe the refactoring action
Move the contents of the type system modules into the core module and drop the type system modules.

Expected benefit
There is a split package between the core module and the type system modules which causes a problem in OSGI environments. The current OSGI-enabled build already does merge the contents of the type system modules into the core module. This now causes duplicate classes/resources if both the core and the type system modules are on the classpath (which is basically always the case since core has a dependency on them). So on the bottom line, if we just merge those modules into core and remove them otherwise, the world is a nicer place.

@reckart reckart added this to the 3.3.0 milestone Jan 27, 2023
@reckart reckart self-assigned this Jan 27, 2023
reckart added a commit that referenced this issue Jan 27, 2023
- Move content and build aspects of ruta-typesystem and ruta-base-type into ruta-core
- Remove ruta-typesystem and ruta-base-type
reckart added a commit that referenced this issue Jan 27, 2023
…-modules-into-core-module

Issue #118: Merge type system modules into core module
@reckart reckart closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant