Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YETUS-1238. Add code to test gpg signing in initial-patches #327

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

aw-was-here
Copy link
Contributor

No description provided.

@@ -145,12 +145,24 @@ update_version() {
git add "${BASEDIR}/.mvn/maven.config"
}

test_gpg_signing() {
declare binary
echo "**** testing gpg signing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something special about the asterisks ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a "hey look at me!" sort of thing to highlight that if things are broken, this one is the first one to look at.

@ndimiduk
Copy link
Member

Yeah yeah GPG signing !!

@aw-was-here aw-was-here merged commit 9929291 into apache:main Nov 13, 2023
3 checks passed
@aw-was-here aw-was-here deleted the aw/gpg-test branch November 13, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants