Skip to content

Commit

Permalink
[YUNIKORN-2124] Fix incorrect test in queue_test.go#TestNewConfigured…
Browse files Browse the repository at this point in the history
…Queue (#696)

Closes: #696

Signed-off-by: Peter Bacsko <pbacsko@cloudera.com>
  • Loading branch information
brandboat authored and pbacsko committed Nov 23, 2023
1 parent 7d220b5 commit 82b35ad
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions pkg/scheduler/objects/queue_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2223,7 +2223,7 @@ func TestNewConfiguredQueue(t *testing.T) {
assert.Assert(t, resources.Equals(resourceStruct, parent.template.GetMaxResource()))
assert.Assert(t, resources.Equals(resourceStruct, parent.template.GetGuaranteedResource()))

// case 0: leaf can use template
// case 0: managed leaf queue can't use template
leafConfig := configs.QueueConfig{
Name: "leaf_queue",
Parent: false,
Expand All @@ -2237,9 +2237,13 @@ func TestNewConfiguredQueue(t *testing.T) {
assert.NilError(t, err, "failed to create queue: %v", err)
assert.Equal(t, childLeaf.QueuePath, "parent_queue.leaf_queue")
assert.Assert(t, childLeaf.template == nil)
assert.DeepEqual(t, childLeaf.properties, parent.template.GetProperties())
assert.Assert(t, resources.Equals(childLeaf.maxResource, parent.template.GetMaxResource()))
assert.Assert(t, resources.Equals(childLeaf.guaranteedResource, parent.template.GetGuaranteedResource()))
assert.Assert(t, reflect.DeepEqual(childLeaf.properties, leafConfig.Properties))
childLeafMax, err := resources.NewResourceFromConf(leafConfig.Resources.Max)
assert.NilError(t, err, "Resource creation failed")
assert.Assert(t, resources.Equals(childLeaf.maxResource, childLeafMax))
childLeafGuaranteed, err := resources.NewResourceFromConf(leafConfig.Resources.Guaranteed)
assert.NilError(t, err, "Resource creation failed")
assert.Assert(t, resources.Equals(childLeaf.guaranteedResource, childLeafGuaranteed))

// case 1: non-leaf can't use template but it can inherit template from parent
NonLeafConfig := configs.QueueConfig{
Expand Down

0 comments on commit 82b35ad

Please sign in to comment.