Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1984] Expose other config value in the REST response #652

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

Expose other config values in the REST response.

What type of PR is it?

  • - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1984

How should this be tested?

Covered by unit tests.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #652 (5dcfdb2) into master (6e97aa7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   77.73%   77.74%   +0.01%     
==========================================
  Files          79       79              
  Lines       13099    13107       +8     
==========================================
+ Hits        10182    10190       +8     
  Misses       2590     2590              
  Partials      327      327              
Files Coverage Δ
pkg/webservice/handlers.go 80.65% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FrankYang0529 FrankYang0529 self-assigned this Sep 17, 2023
Copy link
Contributor

@manirajv06 manirajv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Minor nit

pkg/webservice/handlers.go Outdated Show resolved Hide resolved
Signed-off-by: PoAn Yang <payang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants