Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YUNIKORN-2188 Improve state transition event to include the eventinfo #730

Closed
wants to merge 2 commits into from

Conversation

zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Nov 24, 2023

What is this PR for?

  1. The PR remove the sendRejectApplicationEvent to change to use state change event, but we need to support eventinfo for every state change.

#629

  1. we should remove the unsued older sendRejectApplicationEvent related logic.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9dcab4) 77.80% compared to head (20fd25f) 77.81%.
Report is 1 commits behind head on master.

❗ Current head 20fd25f differs from pull request most recent head ffca66b. Consider uploading reports for the commit ffca66b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   77.80%   77.81%   +0.01%     
==========================================
  Files          80       80              
  Lines       13400    13394       -6     
==========================================
- Hits        10426    10423       -3     
+ Misses       2649     2647       -2     
+ Partials      325      324       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhuqi-lucas zhuqi-lucas changed the title YUNIKORN-2188 Remove older sendRejectApplicationEvent YUNIKORN-2188 Improve state transition event to include the eventinfo Nov 24, 2023
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants