[YUNIKORN-2185] Rewrite if-else to switch statement #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 77.80% 77.83% +0.02%
==========================================
Files 80 80
Lines 13400 13400
==========================================
+ Hits 10426 10430 +4
+ Misses 2649 2648 -1
+ Partials 325 322 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR rewrite the if-else case in application.go for preventing the
gocriticwarning.What type of PR is it?
Todos
N/A
What is the Jira issue?
YUNIKORN-2185
How should this be tested?
It's been tested by using instruction
gocritic check ./...in local env.Screenshots (if appropriate)
N/A
Questions:
N/A