Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2070] E2e tests for gang_scheduling failed due to containers init were OOM-Killed #698

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

To prevent the OOM-Killed error in gang_scheduling e2e test.
This PR changed placeholder's memory limit from 10M to 20M.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

Need several trial run to check the solution is valid.

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2070

How should this be tested?

Existing E2E test should pass, and no OOM-Killed error happened in gang_scheduling e2e test.

Screenshots (if appropriate)

Questions:

NA

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #698 (56b0c6c) into master (d18f7c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   71.90%   71.90%           
=======================================
  Files          51       51           
  Lines        8098     8098           
=======================================
  Hits         5823     5823           
  Misses       2075     2075           
  Partials      200      200           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants