Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2092] Remove spark-operator AppManager #711

Closed
wants to merge 2 commits into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Removes the spark-k8s-operator AppManager plugin, as well as all generated code necessary for its implementation. This simplifies the AppManager code, as only the general plugin remains (and will be refactored out later).

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2092

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Oct 30, 2023
@craigcondit craigcondit force-pushed the YUNIKORN-2092 branch 2 times, most recently from 6c47198 to 02e102c Compare October 30, 2023 17:45
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #711 (15095ad) into master (b1e44a5) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 15095ad differs from pull request most recent head e0bc38a. Consider uploading reports for the commit e0bc38a to get more accurate results

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   71.64%   71.64%   -0.01%     
==========================================
  Files          50       50              
  Lines        7950     7948       -2     
==========================================
- Hits         5696     5694       -2     
  Misses       2056     2056              
  Partials      198      198              
Files Coverage Δ
pkg/appmgmt/appmgmt.go 56.45% <ø> (-1.37%) ⬇️
pkg/log/logger.go 86.76% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craigcondit
Copy link
Contributor Author

Rebased on latest master (merge conflict in yunikorn-rbac.yaml).

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

I'd like to as @wilfred-s to take a look at it too just to be sure.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just code removal, not functionality change for Spark jobs

@wilfred-s wilfred-s closed this in c8e7eca Nov 2, 2023
@craigcondit craigcondit deleted the YUNIKORN-2092 branch November 2, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants