-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2131] Add ready-to-use example for peemption #723
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 49 49
Lines 7956 7956
=======================================
Hits 5720 5720
Misses 2039 2039
Partials 197 197 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It is a good example to show how to perform preemption. Thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenyulin0719 this is a great patch. one small question left.
- name: sandbox | ||
resources: | ||
max: | ||
{memory: 1000Mi, vcore: 1000m} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this max
required for the demo? If not, it seems we can remove this queue sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is. Without max resources setting, the available resource depends on users' nodes and it will be hard to determine pod resource requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chia7712 and @FrankYang0529 's review.
Yes, the max resource is required, otherwise the preemption won't be triggered if the queues have enough resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it and thanks for sharing. I will test it manually later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
Add an immediately usable example to reduce the learning curve for users.
The example shows how to config priority queue and demonstrates below behaviors of preemption:
What type of PR is it?
Todos
NA
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2131
How should this be tested?
Follow the example steps in yunikorn-k8shim/deployments/examples/preemption/README.md
Screenshots (if appropriate)
NA
Questions:
NA