Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2148] bump grpc/otelgrpc for CVE-2023-47108 #727

Closed
wants to merge 2 commits into from

Conversation

wilfred-s
Copy link
Contributor

What is this PR for?

High CVE fix

Needs to be pulled back into branch-1.4 when fixed

What type of PR is it?

  • - Bug Fix

What is the Jira issue?

How should this be tested?

NA

@FrankYang0529
Copy link
Member

I run go mod tidy again and there is a change in go.mod. Finally, make lint can work without error.

diff --git a/go.mod b/go.mod
index 07b33335..3db611dd 100644
--- a/go.mod
+++ b/go.mod
@@ -129,7 +129,7 @@ require (
        golang.org/x/net v0.17.0 // indirect
        golang.org/x/oauth2 v0.11.0 // indirect
        golang.org/x/sync v0.3.0 // indirect
-       golang.org/x/sys v0.13.0 // indirect
+       golang.org/x/sys v0.14.0 // indirect
        golang.org/x/term v0.13.0 // indirect
        golang.org/x/text v0.13.0 // indirect
        golang.org/x/time v0.3.0 // indirect

@wilfred-s
Copy link
Contributor Author

I run go mod tidy again and there is a change in go.mod. Finally, make lint can work without error.

-       golang.org/x/sys v0.13.0 // indirect
+       golang.org/x/sys v0.14.0 // indirect

I explicitly left that out as we have pinned x/sys to 0.13 in all repositories. make lint passed without that update locally. After playing around it passes or fails. Was not able to reproduce consistently how or why that happens. Passes consistently when applied ❓

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2b8ebd) 71.89% compared to head (c843dfb) 71.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   71.89%   71.87%   -0.03%     
==========================================
  Files          49       49              
  Lines        7956     7956              
==========================================
- Hits         5720     5718       -2     
- Misses       2039     2041       +2     
  Partials      197      197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in 5cc17f4 Nov 14, 2023
wilfred-s added a commit that referenced this pull request Nov 14, 2023
Closes: #727

Signed-off-by: Wilfred Spiegelenburg <wilfreds@apache.org>
@wilfred-s wilfred-s deleted the YUNIKORN-2148 branch November 21, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants