Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2184] Fix goconst linter issues #736

Closed
wants to merge 2 commits into from

Conversation

targetoee
Copy link
Contributor

What is this PR for?

This PR focus on fix linter issues about goconst warning. Some const are set for better reuse.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

This PR only fixes the parts which are pointed out by the linter.
While in application_test.go, the naming of variable names doesn't have a unified format.
It would be better to reformat that, and one way to achieve this is by setting common variables in util_test.go and reuse them.

What is the Jira issue?

YUNIKORN-2184

How should this be tested?

It's been test using ./tools/golanci-lint run ./... | grep goconst to checkout all the goconst waring are fixed.

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afbb4a8) 69.46% compared to head (dad41eb) 69.46%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files          50       50           
  Lines        7993     7993           
=======================================
  Hits         5552     5552           
  Misses       2252     2252           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants