[YUNIKORN-1956] Add wildcard user/group limit e2e tests #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
YUNIKORN-1956
branch
from
671b243 to
ec57ad7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
==========================================
- Coverage 69.52% 69.46% -0.07%
==========================================
Files 50 50
Lines 7993 7993
==========================================
- Hits 5557 5552 -5
- Misses 2248 2252 +4
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
manirajv06
reviewed
Dec 1, 2023
| ginkgo.By("Update config") | ||
| annotation = "ann-" + common.RandSeq(10) | ||
| // The wait wrapper still can't fully guarantee that the config in AdmissionController has been updated. | ||
| yunikorn.WaitForAdmissionControllerRefreshConfAfterAction(func() { |
There was a problem hiding this comment.
Why is it so? If it is known issue, Do we have any jira to track this? I remember some one else too raised this issue.
There was a problem hiding this comment.
I think this is introduced from https://issues.apache.org/jira/browse/YUNIKORN-1998. I just copy-paste from previous test cases.
manirajv06
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Specific user/group limits + wild card user/group limits to ensure order of precedence:
5a) When the user limit is specified, it should be considered for that specific user
5b) When the user limit is not specified, the wild card user limit should be considered for that specific user
6a) When the group limit is specified, it should be considered for that specific group
6b) When the group limit is not specified, the wild card group limit should be considered for that specific group
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1956