Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2241] Refactor group/user limit e2e test #745

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2241] Refactor group/user limit e2e test #745

wants to merge 1 commit into from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Dec 6, 2023

What is this PR for?

refactor hard code partition into pre-defined partition const due to its usage on checkusage() to make style more alignable.

other constants like root would be hard to aligned.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2241

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pegasas pegasas marked this pull request as ready for review December 6, 2023 08:48
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other constants like root would be hard to aligned.

The root queue is something that is fixed and defined in the same constants file: constants.RootQueue.
Same replacement can be made for that one.

@pegasas
Copy link
Contributor Author

pegasas commented Dec 7, 2023

other constants like root would be hard to aligned.

The root queue is something that is fixed and defined in the same constants file: constants.RootQueue. Same replacement can be made for that one.

Hi, @wilfred-s ,
It is a good suggestion.
I make another version of this.
feel free to review when anytime you are available.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2738571) 69.43% compared to head (82ea26f) 69.46%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   69.43%   69.46%   +0.02%     
==========================================
  Files          50       50              
  Lines        7993     7993              
==========================================
+ Hits         5550     5552       +2     
+ Misses       2254     2252       -2     
  Partials      189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko
Copy link
Contributor

pbacsko commented Jan 4, 2024

@pegasas what is required for this PR? Do you have pending changes?

@pegasas
Copy link
Contributor Author

pegasas commented Jan 5, 2024

@pegasas what is required for this PR? Do you have pending changes?

no, pending for merging now.

@pbacsko pbacsko self-requested a review January 5, 2024 06:59
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in 3ab3b2d Jan 5, 2024
@pegasas pegasas deleted the yunikorn-2241 branch January 5, 2024 07:07
chenyulin0719 pushed a commit to chenyulin0719/yunikorn-k8shim that referenced this pull request Jan 9, 2024
Closes: apache#745

Signed-off-by: Peter Bacsko <pbacsko@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants