-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2241] Refactor group/user limit e2e test #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other constants like
root
would be hard to aligned.
The root
queue is something that is fixed and defined in the same constants file: constants.RootQueue
.
Same replacement can be made for that one.
Hi, @wilfred-s , |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 69.43% 69.46% +0.02%
==========================================
Files 50 50
Lines 7993 7993
==========================================
+ Hits 5550 5552 +2
+ Misses 2254 2252 -2
Partials 189 189 ☔ View full report in Codecov by Sentry. |
@pegasas what is required for this PR? Do you have pending changes? |
no, pending for merging now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Closes: apache#745 Signed-off-by: Peter Bacsko <pbacsko@cloudera.com>
What is this PR for?
refactor hard code partition into pre-defined partition const due to its usage on
checkusage()
to make style more alignable.other constants like
root
would be hard to aligned.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2241
How should this be tested?
Screenshots (if appropriate)
Questions: