Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2850] Watch configmap only in yunikorn's deployed namespace #942

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[YUNIKORN-2850] Watch configmap only in yunikorn's deployed namespace #942

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e936b0
Enhance namespace restriction logic in informers
400Ping Nov 29, 2024
facfa3a
Fix and refine namespace restriction logic and tests
400Ping Nov 29, 2024
380a257
Change imports back
400Ping Nov 30, 2024
4a0fb28
Revert "Change imports back"
400Ping Dec 6, 2024
f303f67
Revert "Fix and refine namespace restriction logic and tests"
400Ping Dec 6, 2024
6451cfb
Revert "Enhance namespace restriction logic in informers"
400Ping Dec 6, 2024
06179ea
Restrict ConfigMap informer to specific namespace
400Ping Dec 6, 2024
644e2bd
Add prints to check namespace
400Ping Dec 6, 2024
0c529a2
Revert "Add prints to check namespace"
400Ping Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/shim/scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
kubeClient := client.NewKubeClient(configs.KubeConfig)

// we have disabled re-sync to keep ourselves up-to-date
informerFactory := informers.NewSharedInformerFactory(kubeClient.GetClientSet(), 0)
informerFactory := informers.NewSharedInformerFactoryWithOptions(kubeClient.GetClientSet(), 0, informers.WithNamespace(configs.Namespace))

Check warning on line 70 in pkg/shim/scheduler.go

View check run for this annotation

Codecov / codecov/patch

pkg/shim/scheduler.go#L70 

Added line #L70 was not covered by tests

apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs, false)
context := cache.NewContextWithBootstrapConfigMaps(apiFactory, bootstrapConfigMaps)
Expand Down
Loading