Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alluxio #2900

Closed
wants to merge 2 commits into from
Closed

Alluxio #2900

wants to merge 2 commits into from

Conversation

apc999
Copy link

@apc999 apc999 commented Mar 29, 2018

What is this PR for?

Zeppelin provides an Alluxio interpreter compiled with Alluxio client v1.0.0, which was released about two years ago. Alluxio 1.0.0 client will not work with Alluxio 1.4 or later. So in order to use Zeppelin with latest Alluxio, we need to increment the version.

This JIRA aims to bump the version of Alluxio from 1.0.0 to 1.7.1 (the latest release in March 2018)

What type of PR is it?

[Improvement]

What is the Jira issue?

ZEPPELIN-3373

How should this be tested?

Manual test:

  • Build Zeppelin with this patch
  • Launch Zeppelin Alluxio interpreter and test the interpreter.

Screenshots (if appropriate)

Screenshot

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? docs needs to be updated

@apc999 apc999 closed this Mar 29, 2018
@apc999 apc999 reopened this Apr 4, 2018
@apc999
Copy link
Author

apc999 commented Apr 6, 2018

anyone to review or comment this PR?

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -52,12 +54,50 @@
import org.apache.zeppelin.interpreter.InterpreterResult.Code;
import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;

@Ignore("https://alluxio.atlassian.net/browse/ALLUXIO-3142")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this disables the whole test?

@@ -34,15 +35,16 @@

import alluxio.AlluxioURI;
import alluxio.Constants;
import alluxio.client.FileSystemTestUtils;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so no more FileSystemTestUtils we can use?

if (args.length > 0 && args[0].equals("help")) {
System.out.println(getCommandList());
} else {
commandResult = fs.run(args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a replacement of the command list for help?

@@ -106,7 +106,15 @@

<dependency>
<groupId>org.alluxio</groupId>
<artifactId>alluxio-core-server</artifactId>
<artifactId>alluxio-core-common</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list needs to be updated https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE#L103

if we are not using core-server for example, plus new version numbers

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apc999 any update?

@apc999
Copy link
Author

apc999 commented Apr 23, 2018

@felixcheung hi I am just back from a trip and I will work on this now

@felixcheung
Copy link
Member

ping

1 similar comment
@jongyoul
Copy link
Member

jongyoul commented Jul 4, 2018

ping

@antonkulaga
Copy link

@apc999 could you please update the client to 1.8.0 ?

@felixcheung
Copy link
Member

ping?

@rblaine95
Copy link

Any plans to update to Alluxio Shell 2.0.0?

@jongyoul
Copy link
Member

We are currently providing Alluxio 2.5 so I'll close this PR. Thank you for your interest.

@jongyoul jongyoul closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants