-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alluxio #2900
Alluxio #2900
Conversation
anyone to review or comment this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the PR title as described here https://github.com/apache/zeppelin/blob/master/.github/PULL_REQUEST_TEMPLATE
@@ -52,12 +54,50 @@ | |||
import org.apache.zeppelin.interpreter.InterpreterResult.Code; | |||
import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion; | |||
|
|||
@Ignore("https://alluxio.atlassian.net/browse/ALLUXIO-3142") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this disables the whole test?
@@ -34,15 +35,16 @@ | |||
|
|||
import alluxio.AlluxioURI; | |||
import alluxio.Constants; | |||
import alluxio.client.FileSystemTestUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so no more FileSystemTestUtils we can use?
if (args.length > 0 && args[0].equals("help")) { | ||
System.out.println(getCommandList()); | ||
} else { | ||
commandResult = fs.run(args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a replacement of the command list for help?
@@ -106,7 +106,15 @@ | |||
|
|||
<dependency> | |||
<groupId>org.alluxio</groupId> | |||
<artifactId>alluxio-core-server</artifactId> | |||
<artifactId>alluxio-core-common</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this list needs to be updated https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE#L103
if we are not using core-server for example, plus new version numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apc999 any update?
@felixcheung hi I am just back from a trip and I will work on this now |
ping |
1 similar comment
ping |
@apc999 could you please update the client to 1.8.0 ? |
ping? |
Any plans to update to Alluxio Shell 2.0.0? |
We are currently providing Alluxio 2.5 so I'll close this PR. Thank you for your interest. |
What is this PR for?
Zeppelin provides an Alluxio interpreter compiled with Alluxio client v1.0.0, which was released about two years ago. Alluxio 1.0.0 client will not work with Alluxio 1.4 or later. So in order to use Zeppelin with latest Alluxio, we need to increment the version.
This JIRA aims to bump the version of Alluxio from 1.0.0 to 1.7.1 (the latest release in March 2018)
What type of PR is it?
[Improvement]
What is the Jira issue?
ZEPPELIN-3373
How should this be tested?
Manual test:
Screenshots (if appropriate)
Screenshot
Questions: