Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-5249 upgrade libthrift due to CVEs #4327

Closed
wants to merge 3 commits into from

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Mar 21, 2022

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

  • upgrade libthrift due to CVEs and bug fixes
  • I have ignored https://issues.apache.org/jira/browse/ZEPPELIN-4107 - but using libthrift 0.15.0 with classes generated with 0.13.0 compiler should still work and we get the benefit of the runtime fixes in libthrift 0.15.0

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Strongly recommended: add automated unit tests for any new or changed behavior
  • Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@pjfanning pjfanning changed the title ZEPPELIN-5249 upgrade thrift due to CVEs ZEPPELIN-5249 upgrade libthrift due to CVEs Mar 21, 2022
@Reamer
Copy link
Contributor

Reamer commented Mar 21, 2022

We have some problems with a thrift update. Take a look at #4089.
Maybe it will work without a maven-shade-plugin update and my approaches in https://github.com/Reamer/zeppelin/tree/interpreter_shade

@pjfanning
Copy link
Contributor Author

pjfanning commented Mar 21, 2022

@Reamer I see the failing tests. Cassandra jars may need to be upgraded. Also, Hive jars may need to be upgraded - it appears old versions of Hive rely on out of date libthrift but that Hive has been upgraded recently (https://issues.apache.org/jira/browse/HIVE-25098) - the HIve issue seems to be at least 1 issue affecting Spark tests

@pjfanning pjfanning closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants