Fix output locations #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2021 14:39
We don't have to wait for these, but it'd be nice to actually see if the changes we make still let the benchmarks run and complete, if we want.
|
The benchmarks are working again. See #70 |
|
Wow! That's cool. I guess, the change in the output happened to be more intrusive than expected. |
It only took a dozen lines or so to adapt here, so the change wasn't intrusive per se. But I do think the way we landed the feature may have introduced a bit of unneeded complication and slowdown. We can talk about it on a bit on Monday maybe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apalache-mc/apalache#1059
This updates the benchmark tests to take account of the new log output configuration and locations introduced in #1036 and related PRs.
The first commit just autoformats the python file. The only relevant changes are in 907a71b