Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Rewrite S \subseteq T #1408

Closed
konnov opened this issue Feb 24, 2022 · 3 comments · Fixed by #1621
Closed

[FEATURE] Rewrite S \subseteq T #1408

konnov opened this issue Feb 24, 2022 · 3 comments · Fixed by #1621
Assignees

Comments

@konnov
Copy link
Collaborator

konnov commented Feb 24, 2022

We now have two implementations of S \subseteq T:

There is no need for these rules. When S and T are general sets, we can rewrite the S \subseteq T as \A x \in S: x \in T. When S is a general set and T is SUBSET V, we can rewrite S \subseteq SUBSET V as \A x \in S: x \ in V. This will open space for optimizations.

Related to #1103.

@p-offtermatt
Copy link
Collaborator

Could you double-check the second part of the issue?
\A x \in S: x \ in V seems like the rewriting for S \in SUBSET V, not for S \subseteq SUBSET V.
A valid rewriting for S \subseteq SUBSET V that avoids expanding SUBSET might be via double quantification: \A X \in S: \A x \in X: x \in V.
But please correct me if I overlooked something!

@Kukovec
Copy link
Collaborator

Kukovec commented Apr 11, 2022

\A x \in S: x \in V <=>
S \subseteq V
S \subseteq SUBSET V <=>
\A x \in S: x \in SUBSET V <=>
\A x \in S: x \subseteq V <=>
\A x \in S: \A y \in x: y \in V

@Kukovec
Copy link
Collaborator

Kukovec commented Apr 11, 2022

Just remember to recursively call rewrite (or transform or w/e):

rewrite(S \subseteq V) = rewrite(\A x \in rewrite(S): x \in rewrite(V))

This was referenced Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants