Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rewriting subseteq with forall quantification in Keramelizer #1621

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

p-offtermatt
Copy link
Collaborator

@p-offtermatt p-offtermatt commented Apr 12, 2022

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

@p-offtermatt p-offtermatt linked an issue Apr 12, 2022 that may be closed by this pull request
@p-offtermatt p-offtermatt marked this pull request as draft April 12, 2022 08:28
@p-offtermatt p-offtermatt marked this pull request as ready for review April 12, 2022 08:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #1621 (48b138c) into unstable (cc1d8d1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           unstable    #1621      +/-   ##
============================================
+ Coverage     75.13%   75.17%   +0.03%     
============================================
  Files           356      356              
  Lines         11555    11568      +13     
  Branches        541      543       +2     
============================================
+ Hits           8682     8696      +14     
+ Misses         2873     2872       -1     
Impacted Files Coverage Δ
...scala/at/forsyte/apalache/tla/pp/Keramelizer.scala 97.46% <100.00%> (+2.01%) ⬆️
.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala 96.47% <0.00%> (-1.18%) ⬇️
...he/io/annotations/parser/CommentPreprocessor.scala 96.70% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1d8d1...48b138c. Read the comment docs.

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some style-preference comments, the only required fix are the types of forall, which should be Boolean.

@p-offtermatt p-offtermatt merged commit d292da4 into unstable Apr 12, 2022
@p-offtermatt p-offtermatt deleted the 1408-feature-rewrite-s-subseteq-t branch April 19, 2022 07:39
thpani added a commit that referenced this pull request May 5, 2022
This is the same rewriting as applied in Keramelizer in
#1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Rewrite S \subseteq T
3 participants