Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inliner fails to inline operators #283

Closed
konnov opened this issue Oct 15, 2020 · 3 comments · Fixed by #301
Closed

[BUG] Inliner fails to inline operators #283

konnov opened this issue Oct 15, 2020 · 3 comments · Fixed by #301
Assignees
Labels
Milestone

Comments

@konnov
Copy link
Collaborator

konnov commented Oct 15, 2020

Somewhat unexpected, the following simple piece of code does not work:

----------------------------- MODULE Callback ----------------------------      
EXTENDS Integers

VARIABLES x

Pick(Cb(_)) ==
    \E i \in 1..10:
        Cb(i)

Init ==
    LET Cb(i) ==
        x = i
    IN
    Pick(Cb)

Next ==
    LET Cb(i) ==
        x' = i
    IN
    Pick(Cb)

Inv ==
    x > 0
==========================================================================
@konnov konnov added the bug label Oct 15, 2020
@konnov konnov added this to the v0.12.0-user-care milestone Oct 15, 2020
@Kukovec
Copy link
Collaborator

Kukovec commented Oct 16, 2020

While the specification seems to violate FlatLanguagePredicate, it is not an issue with inlining, as the inliner produces the expected output.
We should consider removing (higher-order) operators from the module, once they have been inlined in Init and Next.

@konnov konnov self-assigned this Oct 16, 2020
@konnov
Copy link
Collaborator Author

konnov commented Oct 16, 2020

Thanks! We should filter out the operators that are not required for the further model checking pass. I will pick this issue.

@konnov
Copy link
Collaborator Author

konnov commented Oct 26, 2020

This is fixed in #301

@konnov konnov closed this as completed Oct 26, 2020
konnov added a commit that referenced this issue Oct 27, 2020
inline lambdas and fix #283 (filtered unused operators)
@konnov konnov modified the milestones: v0.12.0-user-care, backlog2020 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants