Add --profiling flag #1065
Merged
Add --profiling flag #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 28, 2021 17:58
- Followup to #1025 - Required for #1059 This flag is proposed in the ADR for the OutputManager but wasn't implemented in #1025, which left us without a way to enable the generation of the profile-rules.txt file that used to always be created (other than using the global config). The benchmarks depend on this file being created.
shonfeder
commented
Oct 28, 2021
Comment on lines
-131
to
-145
| // Flags can be passed from options too, e.g. --profile or --write-intermediate | ||
| // Strangly, we currently require data to flow both from the pass options | ||
| // to the output manager and from the manager to the pass options, this this "sync" | ||
| // is by directional. | ||
| // TODO: remove this once all flag operations are moved into PassOptions | ||
| def syncWithOptions(opt: WriteablePassOptions): Unit = { | ||
| opt.get[Boolean]("general", IntermediateFlag) foreach { | ||
| flags += IntermediateFlag -> _ | ||
| } | ||
| opt.get[Boolean]("general", ProfilingFlag) foreach { | ||
| flags += ProfilingFlag -> _ | ||
| } | ||
| opt.set("io.outdir", outDir) | ||
| } | ||
|
|
There was a problem hiding this comment.
Now the data is only one flowing one way: CLI args and the global config go through the OutputManager, and then we use some its determinations to set pass options. So this method becomes unnecessary.
There was a problem hiding this comment.
I agree. We could declare all these flags directly in the singleton
There was a problem hiding this comment.
Cool. We can consider that for a follow up. Run in by Jute and see what he thinks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is proposed in the ADR for the OutputManager but wasn't
implemented in #1025, which left us without a way to enable the
generation of the profile-rules.txt file that used to always be
created (other than using the global config). The benchmarks depend on
this file being created.
make fmt-fix(or had formatting run automatically on all files edited)