Typechecking for new records #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
approved these changes
Apr 28, 2022
| } | ||
|
|
||
| test("invalid field string in record set construction") { | ||
| val invalid = "invalidName" |
There was a problem hiding this comment.
I don't get why this field name is invalid, can you help me understand?
There was a problem hiding this comment.
Good point. I have added a comment. The test is checking that only ValEx(TlaStr(_)) can be passed, not NameEx(_).
Codecov Report
@@ Coverage Diff @@
## unstable #1692 +/- ##
=========================================
Coverage 75.30% 75.31%
=========================================
Files 357 357
Lines 11534 11542 +8
Branches 619 624 +5
=========================================
+ Hits 8686 8693 +7
- Misses 2848 2849 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1688. This PR integrates type checking of new records when
--features=rowsis enabled. As the four integration tests demonstrate, the new type checker reports type errors in examples that were problematic and counterintuitive with the old records.Type checking for variants is not implemented in this PR. It is scheduled for a later one.
make fmt-fix(or had formatting run automatically on all files edited)