Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode function sets as SMT arrays #1701

Merged
merged 5 commits into from
May 3, 2022
Merged

Conversation

rodrigo7491
Copy link
Collaborator

@rodrigo7491 rodrigo7491 commented May 2, 2022

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

This PR makes elements of type FinFunSetT be encoded as SMT arrays. Closes #1680.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #1701 (b98ba8c) into unstable (0fff5ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           unstable    #1701   +/-   ##
=========================================
  Coverage     75.31%   75.31%           
=========================================
  Files           357      357           
  Lines         11541    11543    +2     
  Branches        595      596    +1     
=========================================
+ Hits           8692     8694    +2     
  Misses         2849     2849           
Impacted Files Coverage Δ
...rsyte/apalache/tla/bmcmt/smt/Z3SolverContext.scala 81.28% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fff5ac...b98ba8c. Read the comment docs.

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rodrigo7491 rodrigo7491 merged commit d0878ca into unstable May 3, 2022
@rodrigo7491 rodrigo7491 deleted the ro/funSets-as-arrays branch May 3, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Z3Exception with arrays encoding: domain <> parameter sort mismatch
3 participants